Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sdk-metrics): fix typos and add missing parameter docs #3244

Merged
merged 6 commits into from
Sep 13, 2022
Merged

docs(sdk-metrics): fix typos and add missing parameter docs #3244

merged 6 commits into from
Sep 13, 2022
+9 −6

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Spotted some typos and missing parameter docs in the metrics SDK package. This PR addresses them. 🙂

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc pichlermarc marked this pull request as ready for review September 9, 2022 09:56
@pichlermarc pichlermarc requested a review from a team September 9, 2022 09:56
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #3244 (2c9777a) into main (032f68f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         203      203           
  Lines        6606     6606           
  Branches     1389     1389           
=======================================
  Hits         6163     6163           
  Misses        443      443
Impacted Files Coverage Δ
.../opentelemetry-sdk-metrics/src/aggregator/types.ts 100.00% <ø> (ø)
...elemetry-sdk-metrics/src/state/MeterSharedState.ts 96.15% <ø> (ø)
...y-sdk-metrics/src/state/TemporalMetricProcessor.ts 98.21% <ø> (ø)
...es/opentelemetry-sdk-metrics/src/view/Predicate.ts 100.00% <ø> (ø)

@pichlermarc pichlermarc changed the title docs(sdk-metrics): fix typos and add missing parameter docs. docs(sdk-metrics): fix typos and add missing parameter docs Sep 9, 2022
@legendecas legendecas added the sdk:metrics Issues and PRs related to the Metrics SDK label Sep 13, 2022
@pichlermarc pichlermarc merged commit bd0a77f into open-telemetry:main Sep 13, 2022
@pichlermarc pichlermarc deleted the docs/sdk-metrics branch September 13, 2022 11:31
@dyladan dyladan mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
sdk:metrics Issues and PRs related to the Metrics SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pichlermarc @dyladan @legendecas